Skip to content

esm: fix support for URL instances in register #49655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 3 commits into from
Sep 17, 2023
Merged

esm: fix support for URL instances in register #49655

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9093afc
esm: fix support for `URL` instances in `register`
aduh95 Sep 14, 2023
e4362d1
update docs
aduh95 Sep 14, 2023
7fcf394
update JSDoc
aduh95 Sep 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update docs
  • Loading branch information
@aduh95
aduh95 committed Sep 14, 2023
commit e4362d12414d685414f513795cb2eb925fbeff15
12 changes: 8 additions & 4 deletions doc/api/module.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,14 +84,18 @@ isBuiltin('wss'); // false

<!-- YAML
added: v20.6.0
changes:
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/49655
description: Add support for WHATWG URL instances.
-->

> Stability: 1.2 - Release candidate

* `specifier` {string} Customization hooks to be registered; this should be the
same string that would be passed to `import()`, except that if it is relative,
it is resolved relative to `parentURL`.
* `parentURL` {string} If you want to resolve `specifier` relative to a base
* `specifier` {string|URL} Customization hooks to be registered; this should be
the same string that would be passed to `import()`, except that if it is
relative, it is resolved relative to `parentURL`.
* `parentURL` {string|URL} If you want to resolve `specifier` relative to a base
URL, such as `import.meta.url`, you can pass that URL here. **Default:**
`'data:'`
* `options` {Object}
Expand Down