Skip to content

esm: do not give wrong hints when detecting file format #50314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Oct 23, 2023
Merged

esm: do not give wrong hints when detecting file format #50314

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88be143
esm: do not give wrong hints when detecting file format
aduh95 Oct 21, 2023
2eba966
Update test/es-module/test-esm-detect-ambiguous.mjs
aduh95 Oct 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update test/es-module/test-esm-detect-ambiguous.mjs 
Co-authored-by: Geoffrey Booth <webadmin@geoffreybooth.com>
  • Loading branch information
@aduh95 @GeoffreyBooth
aduh95 and GeoffreyBooth authored Oct 21, 2023
commit 2eba966bf83c001cf2578747f3b0bf2ee76c20d8
2 changes: 1 addition & 1 deletion test/es-module/test-esm-detect-ambiguous.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ describe('--experimental-detect-module', { concurrency: true }, () => {
'--experimental-detect-module',
'--no-warnings',
'--loader',
`data:text/javascript,import{writeSync}from"node:fs";export ${encodeURIComponent(
`data:text/javascript,import { writeSync } from "node:fs"; export ${encodeURIComponent(
async function resolve(s, c, next) {
const result = await next(s, c);
writeSync(1, result.format + '\n');
Expand Down