Skip to content

zlib: expose zlib.crc32() #52692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 6 commits into from
May 2, 2024
Merged

zlib: expose zlib.crc32() #52692

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
53fb0e4
zlib: expose zlib.crc32()
joyeecheung Apr 25, 2024
d9057fc
fixup! zlib: expose zlib.crc32()
joyeecheung Apr 25, 2024
d4fc5ca
fixup! fixup! zlib: expose zlib.crc32()
joyeecheung Apr 25, 2024
b26c0c6
fixup! fixup! zlib: expose zlib.crc32()
joyeecheung Apr 26, 2024
905c481
fixup! zlib: expose zlib.crc32()
joyeecheung Apr 26, 2024
58d9da4
fixup! fixup! zlib: expose zlib.crc32()
joyeecheung Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! zlib: expose zlib.crc32() 
Co-authored-by: Anna Henningsen <github@addaleax.net>
  • Loading branch information
@joyeecheung @addaleax
joyeecheung and addaleax authored Apr 26, 2024
commit 905c4812a3af767fb02786c571587bb1bdda2eeb
4 changes: 2 additions & 2 deletions src/node_zlib.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1286,10 +1286,10 @@ struct MakeClass {
}
};

template <typename T>
template <typename T, typename F>
T CallOnSequence(v8::Isolate* isolate,
Local<Value> value,
std::function<T(const char* data, size_t size)> callback) {
F callback) {
if (value->IsString()) {
Utf8Value data(isolate, value);
return callback(data.out(), data.length());
Expand Down