Skip to content

tools: fix V8 update workflow #52822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
May 5, 2024
Merged

tools: fix V8 update workflow #52822

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
603f07d
tools: fix V8 update workflow
aduh95 May 3, 2024
ad36176
oops
aduh95 May 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
oops 
Co-authored-by: Michaël Zasso <targos@protonmail.com>
  • Loading branch information
@aduh95 @targos
aduh95 and targos authored May 3, 2024
commit ad361760f068a530d9a7072c7199a03ca62f6d8c
2 changes: 1 addition & 1 deletion tools/dep_updaters/update-v8-patch.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ BASE_DIR=$(cd "$(dirname "$0")/../.." && pwd)

cd "$BASE_DIR"

CAN_UPDATE=$(git node v8 minor --v8-dir /Users/duhamean/Documents/v8/v8/ | grep -q "V8 is up-to-date" || echo "1")
CAN_UPDATE=$(git node v8 minor | grep -q "V8 is up-to-date" || echo "1")

if [ -z "$CAN_UPDATE" ]; then
echo "Skipped because V8 is on the latest version."
Expand Down