Skip to content

build: only generate specified build type ninja files #53511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Jun 22, 2024
Merged

build: only generate specified build type ninja files #53511

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
build: only generate specified build type files 
Release and Debug build configurations can not be shared, only
generate specified configuration in `configure`.
  • Loading branch information
@legendecas
legendecas committed Jun 19, 2024
commit 95a97e1e7bfaf5486d0561587ccb96335a97e172
2 changes: 1 addition & 1 deletion configure.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2253,7 +2253,7 @@ def make_bin_override():
gyp_args += ['-Dpython=' + python]

if options.use_ninja:
gyp_args += ['-f', 'ninja-' + flavor]
gyp_args += ['-f', 'ninja-' + flavor, '-G', 'config=' + config['BUILDTYPE']]
Comment thread
joyeecheung marked this conversation as resolved.
elif flavor == 'win' and sys.platform != 'msys':
gyp_args += ['-f', 'msvs', '-G', 'msvs_version=auto']
else:
Expand Down