Skip to content

src: improve utf8 string generation performance #54873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 4 commits into from
Sep 17, 2024
+47 −21
Merged

src: improve utf8 string generation performance #54873

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9ea7fc4
src: improve utf8 string generation performance
anonrig Sep 10, 2024
435fa04
Update util.cc
anonrig Sep 10, 2024
cb36b86
Update src/util.cc
anonrig Sep 12, 2024
4b28cf1
Update src/util.cc
anonrig Sep 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update src/util.cc 
Co-authored-by: Robert Nagy <ronagy@icloud.com>
  • Loading branch information
@anonrig @ronag
anonrig and ronag authored Sep 14, 2024
commit 4b28cf1a74209e01adc024264c9e937b5bf63062
5 changes: 2 additions & 3 deletions src/util.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,10 +115,9 @@ static void MakeUtf8String(Isolate* isolate,

// Add +1 for null termination.
target->AllocateSufficientStorage(expected_length + 1);
target->SetLengthAndZeroTerminate(expected_length);
auto actual_length = simdutf::convert_latin1_to_utf8(
const auto actual_length = simdutf::convert_latin1_to_utf8(
const_char, value_length, target->out());
target->SetLength(actual_length);
target->SetLengthAndZeroTerminate(actual_length);
return;
}

Expand Down