Skip to content

lib: remove startsWith/endsWith primordials for char checks #55407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 5 commits into from
Oct 19, 2024
Merged

lib: remove startsWith/endsWith primordials for char checks #55407

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3706c83
lib: remove startsWith/endsWith primordials for char checks
gurgunday Oct 16, 2024
1be2c43
lint: remove unused vars
gurgunday Oct 16, 2024
e2ba06c
revert: webidl2 change
gurgunday Oct 16, 2024
5732d4d
use .length to check for empty string
gurgunday Oct 16, 2024
0bd51d5
add assert to `addNumericSeparator`
gurgunday Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use .length to check for empty string
  • Loading branch information
@gurgunday
gurgunday committed Oct 16, 2024
commit 5732d4dc99d6255efaf1dca95fa57bc330578b95
2 changes: 1 addition & 1 deletion lib/internal/modules/esm/fetch_module.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ allowList.addRange('127.0.0.1', '127.255.255.255');
async function isLocalAddress(hostname) {
try {
if (
hostname &&
hostname.length &&
hostname[0] === '[' &&
hostname[hostname.length - 1] === ']'
) {
Expand Down
2 changes: 1 addition & 1 deletion lib/internal/process/per_thread.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ function buildAllowedFlags() {
}

function isAccepted(to) {
if (!to || to[0] !== '-' || to === '--') return true;
if (!to.length || to[0] !== '-' || to === '--') return true;
const recursiveExpansion = aliases.get(to);
if (recursiveExpansion) {
if (recursiveExpansion[0] === to)
Expand Down