Skip to content

test_runner: add level-based diagnostic handling for reporter #55964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hpatel292-seneca wants to merge 11 commits into from
Closed

test_runner: add level-based diagnostic handling for reporter #55964

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
7dda539
test_runner: add level parameter to reporter.diagnostic
hpatel292-seneca Nov 23, 2024
c618874
test_runner: enhance #handleEvent to handle levels
hpatel292-seneca Nov 23, 2024
2ac841c
test_runner: extend reporterColorMap for levels
hpatel292-seneca Nov 23, 2024
1ca0d45
test_runner: set level for coverage threshold
hpatel292-seneca Nov 23, 2024
038b0f8
test_runner: remove debug from reporterColorMap
hpatel292-seneca Nov 24, 2024
b490d9d
doc: update 'test:diagnostic' event to include level parameter
hpatel292-seneca Nov 26, 2024
3e4d5e6
test: add test for spec reporter red color output
hpatel292-seneca Nov 27, 2024
4048621
test: disable no-control-regex for color regex
hpatel292-seneca Nov 27, 2024
33b961d
doc: clarify diagnostic behavior in API docs
hpatel292-seneca Nov 28, 2024
b1c8033
test: validate diagnostic events in test runner
hpatel292-seneca Dec 13, 2024
c06e9e1
test: Fix Lint error
hpatel292-seneca Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: Fix Lint error 
Added eslint-disable-next-line to
bypass no-unused-vars check

ref: #55964
  • Loading branch information
@hpatel292-seneca
hpatel292-seneca committed Dec 13, 2024
commit c06e9e180d476f59398fc8f326be77773fd16a40
2 changes: 1 addition & 1 deletion test/parallel/test-runner-run.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ describe('require(\'node:test\').run', { concurrency: true }, () => {
stream.on('test:diagnostic', (event) => {
diagnosticEvents.push(event);
});

// eslint-disable-next-line no-unused-vars
for await (const _ of stream);
assert(diagnosticEvents.length > 0, 'No diagnostic events were emitted');
const infoEvent = diagnosticEvents.find((e) => e.level === 'info');
Expand Down