Skip to content

lib: fix fs.readdir recursive async #56041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduh95 merged 3 commits into from
Dec 5, 2024
Merged

lib: fix fs.readdir recursive async #56041

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
982a50e
lib: fix fs.readdir recursive async
RafaelGSS Nov 27, 2024
6ca4cf4
fixup! lib: fix fs.readdir recursive async
RafaelGSS Nov 29, 2024
16a29cb
fixup! fixup! lib: fix fs.readdir recursive async
RafaelGSS Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! fixup! lib: fix fs.readdir recursive async
  • Loading branch information
@RafaelGSS
RafaelGSS committed Dec 2, 2024
commit 16a29cb64fc06553962226d3c055150c25d24a11
2 changes: 1 addition & 1 deletion lib/fs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1433,7 +1433,7 @@ function readdirRecursive(basePath, options, callback) {
// The first array is the names, and the second array is the types.
// They are guaranteed to be the same length; hence, setting `length` to the length
// of the first array within the result.
const processReaddirResult = (context) => (context.withFileTypes ? handleDirents(context) : handleFilePaths(context));
const processReaddirResult = (args) => (args.context.withFileTypes ? handleDirents(args) : handleFilePaths(args));

function handleDirents({ result, currentPath, context }) {

@anonrig anonrig Nov 28, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding jsdoc to all newly/updated functions?

@RafaelGSS RafaelGSS Nov 28, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't added jsdoc to these ones because they are not public, they are used inside readdirRecursive (which has JSDoc). It seems a pattern on this file.

const { 0: names, 1: types } = result;
Expand Down