Skip to content

http: add setDefaultHeaders option to http.request #56112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Dec 12, 2024
Merged

http: add setDefaultHeaders option to http.request #56112

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
950b50b
http: add setDefaultHeaders option to http.request
pimterry Dec 2, 2024
ddfdc0f
Update tests to use common.localhostIPv4
pimterry Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update tests to use common.localhostIPv4 
Suggestions from review

Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
@pimterry @lpinca
pimterry and lpinca authored Dec 10, 2024
commit ddfdc0f2d59f3e2c10d75e802eb8b4d42114755a
6 changes: 3 additions & 3 deletions test/parallel/test-http-dont-set-default-headers-with-set-header.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,16 +16,16 @@ const server = http.createServer(common.mustCall(function(req, res) {
res.end('ok');
server.close();
}));
server.listen(0, '127.0.0.1', function() {
server.listen(0, common.localhostIPv4, function() {
const req = http.request({
method: 'POST',
host: '127.0.0.1',
host: common.localhostIPv4,
port: this.address().port,
setDefaultHeaders: false,
});

req.setHeader('test', 'value');
req.setHeader('HOST', `127.0.0.1:${server.address().port}`);
req.setHeader('HOST', `${common.localhostIPv4}:${server.address().port}`);
req.setHeader('foo', ['bar', 'baz']);
req.setHeader('connection', 'close');

Expand Down
6 changes: 3 additions & 3 deletions test/parallel/test-http-dont-set-default-headers-with-setHost.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,16 @@ const http = require('http');

const server = http.createServer(common.mustCall(function(req, res) {
assert.deepStrictEqual(req.rawHeaders, [
'Host', `127.0.0.1:${server.address().port}`,
'Host', `${common.localhostIPv4}:${server.address().port}`,
]);

res.end('ok');
server.close();
}));
server.listen(0, '127.0.0.1', function() {
server.listen(0, common.localhostIPv4, function() {
http.request({
method: 'POST',
host: '127.0.0.1',
host: common.localhostIPv4,
port: this.address().port,
setDefaultHeaders: false,
setHost: true
Expand Down
8 changes: 4 additions & 4 deletions test/parallel/test-http-dont-set-default-headers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ const http = require('http');

const server = http.createServer(common.mustCall(function(req, res) {
assert.deepStrictEqual(req.rawHeaders, [
'host', `127.0.0.1:${server.address().port}`,
'host', `${common.localhostIPv4}:${server.address().port}`,
'foo', 'bar',
'test', 'value',
'foo', 'baz',
Expand All @@ -15,14 +15,14 @@ const server = http.createServer(common.mustCall(function(req, res) {
res.end('ok');
server.close();
}));
server.listen(0, '127.0.0.1', function() {
server.listen(0, common.localhostIPv4, function() {
http.request({
method: 'POST',
host: '127.0.0.1',
host: common.localhostIPv4,
port: this.address().port,
setDefaultHeaders: false,
headers: [
'host', `127.0.0.1:${server.address().port}`,
'host', `${common.localhostIPv4}:${server.address().port}`,
'foo', 'bar',
'test', 'value',
'foo', 'baz',
Expand Down