Skip to content

build: use variable for simdutf path #56196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Dec 11, 2024
Merged

build: use variable for simdutf path #56196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
build: use variable for simdutf path
  • Loading branch information
@codebytere
codebytere committed Dec 10, 2024
commit 2a98409a22401241a796811c54a4f0e47b3ae1f5
6 changes: 5 additions & 1 deletion node.gni
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,15 @@ declare_args() {
# The location of Node.js in source code tree.
node_path = "//node"

# The location of V8, use the one from node's deps by default.
# The location of V8 - use the one from node's deps by default.
node_v8_path = "$node_path/deps/v8"

# The location of OpenSSL - use the one from node's deps by default.
node_openssl_path = "$node_path/deps/openssl"

# The location of simdutf - use the one from node's deps by default.
node_simdutf_path = "$node_path/deps/simdutf"

# The NODE_MODULE_VERSION defined in node_version.h.
node_module_version = exec_script("$node_path/tools/getmoduleversion.py", [], "value")

Expand Down
6 changes: 3 additions & 3 deletions unofficial.gni
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,10 +158,10 @@ template("node_gn_build") {
"deps/nghttp2",
"deps/ngtcp2",
"deps/postject",
"deps/simdutf",
"deps/sqlite",
"deps/uvwasi",
"//third_party/zlib",
"$node_simdutf_path",
"$node_v8_path:v8_libplatform",
]

Expand Down Expand Up @@ -300,8 +300,8 @@ template("node_gn_build") {

executable("node_js2c") {
deps = [
"deps/simdutf",
"deps/uv",
"$node_simdutf_path",
]
sources = [
"tools/js2c.cc",
Expand Down Expand Up @@ -358,7 +358,7 @@ template("node_gn_build") {
"deps/googletest",
"deps/googletest:gtest_main",
"deps/nbytes",
"deps/simdutf",
"$node_simdutf_path",
]

sources = gypi_values.node_cctest_sources
Expand Down