Skip to content

src: lock the thread properly in snapshot builder #56327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Jan 7, 2025
Merged

src: lock the thread properly in snapshot builder #56327

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
src: lock the thread properly in snapshot builder 
Otherwise it can crash DCHECK when V8 expects that at least someone
is locking the current thread.
  • Loading branch information
@joyeecheung
joyeecheung committed Dec 20, 2024
commit 056befb2a2896df995e67774ddbac7a9f56e04f2
2 changes: 2 additions & 0 deletions src/node_snapshotable.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -962,6 +962,8 @@ ExitCode BuildSnapshotWithoutCodeCache(
}

Isolate* isolate = setup->isolate();
v8::Locker locker(isolate);

{
HandleScope scope(isolate);
TryCatch bootstrapCatch(isolate);
Expand Down