Skip to content

meta: add codeowners of security release document #56521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Jan 15, 2025
+3 −0
Merged

meta: add codeowners of security release document #56521

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
219523c
meta: add codeowners of security release document
RafaelGSS Jan 8, 2025
43fc68c
fixup! meta: add codeowners of security release document
RafaelGSS Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,9 @@
/src/permission/* @nodejs/security-wg
/test/parallel/test-permission-* @nodejs/security-wg

# Security Release
/doc/contributing/security-release-process.md @nodejs/security-release

@richardlau richardlau Jan 8, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is the right group for codeowners. The people who follow this process are the security stewards, most of whom are not members of security-release (which is more or less releasers).

@richardlau richardlau Jan 8, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(There is a team for the security stewards, but only in the private org. -- I'm not sure if that's an oversight because the other security-* teams are replicated between the two orgs.)

@RafaelGSS RafaelGSS Jan 8, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I change it to @nodejs/security? We don't have a security stewards group but we could create if needed.

@mhdawson mhdawson Jan 9, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might make sense to use the existing nodejs/security team, however, we do want the security stewards to be in the code owners and I don't think that would do it since we don't have them in a team, and its not certain (not sure on this) they are in the other security teams?

@RafaelGSS RafaelGSS Jan 9, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's worth-it to have a @nodejs/security-stewards, WDYT?

@mhdawson mhdawson Jan 9, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm + to adding @nodejs/security-stewards


# Dependency Update Tools

/.github/workflows/tools.yml @nodejs/security-wg
Expand Down