Skip to content

src: integrate ContextifyContext to cppgc #56522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joyeecheung wants to merge 4 commits into from
Closed

src: integrate ContextifyContext to cppgc #56522

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ad3fded
test: add maxCount and gcOptions to gcUntil()
joyeecheung Jan 14, 2025
e67c128
src: use cppgc to manage ContextifyContext
joyeecheung Jan 9, 2025
ed02ac1
fixup! test: add maxCount and gcOptions to gcUntil()
joyeecheung Jan 15, 2025
b18f41a
fixup! src: use cppgc to manage ContextifyContext
joyeecheung Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: add maxCount and gcOptions to gcUntil()
  • Loading branch information
@joyeecheung
joyeecheung committed Jan 15, 2025
commit ad3fdedd0bdb64f5d834d36514aabb90fb955b4b
37 changes: 16 additions & 21 deletions test/common/gc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
const wait = require('timers/promises').setTimeout;
const assert = require('assert');
const common = require('../common');
const { setImmediate } = require('timers/promises');
const gcTrackerMap = new WeakMap();
const gcTrackerTag = 'NODE_TEST_COMMON_GC_TRACKER';

Expand Down Expand Up @@ -40,32 +41,26 @@ function onGC(obj, gcListener) {

/**
* Repeatedly triggers garbage collection until a specified condition is met or a maximum number of attempts is reached.
* This utillity must be run in a Node.js instance that enables --expose-gc.
* @param {string|Function} [name] - Optional name, used in the rejection message if the condition is not met.
* @param {Function} condition - A function that returns true when the desired condition is met.
* @param {number} maxCount - Maximum number of garbage collections that should be tried.
* @param {object} gcOptions - Options to pass into the global gc() function.
* @returns {Promise} A promise that resolves when the condition is met, or rejects after 10 failed attempts.
*/
function gcUntil(name, condition) {
if (typeof name === 'function') {
condition = name;
name = undefined;
}
return new Promise((resolve, reject) => {
let count = 0;
function gcAndCheck() {
setImmediate(() => {
count++;
global.gc();
if (condition()) {
resolve();
} else if (count < 10) {
gcAndCheck();
} else {
reject(name === undefined ? undefined : 'Test ' + name + ' failed');
}
});
async function gcUntil(name, condition, maxCount = 10, gcOptions) {
for (let count = 0; count < maxCount; ++count) {
await setImmediate();
if (gcOptions) {
await global.gc(gcOptions);
} else {
await global.gc(); // Passing in undefined is not the same as empty.
}
gcAndCheck();
});
if (condition()) {
return;
}
}
throw new Error(`Test ${name} failed`);
}

// This function can be used to check if an object factor leaks or not,
Expand Down