Skip to content

test_runner: add level-based diagnostic handling for reporter #57923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 12 commits into from
May 19, 2025
Merged

test_runner: add level-based diagnostic handling for reporter #57923

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
4fd224b
test_runner: add level parameter to reporter.diagnostic
hpatel292-seneca Nov 23, 2024
3c9c4a8
test_runner: enhance #handleEvent to handle levels
hpatel292-seneca Nov 23, 2024
5ef5c9e
test_runner: extend reporterColorMap for levels
hpatel292-seneca Nov 23, 2024
947130e
test_runner: set level for coverage threshold
hpatel292-seneca Nov 23, 2024
c515f56
test_runner: remove debug from reporterColorMap
hpatel292-seneca Nov 24, 2024
e0d74f7
doc: update 'test:diagnostic' event to include level parameter
hpatel292-seneca Nov 26, 2024
0f145bf
test: add test for spec reporter red color output
hpatel292-seneca Nov 27, 2024
2636588
test: disable no-control-regex for color regex
hpatel292-seneca Nov 27, 2024
a1590bb
doc: clarify diagnostic behavior in API docs
hpatel292-seneca Nov 28, 2024
8636dd2
test: validate diagnostic events in test runner
hpatel292-seneca Dec 13, 2024
88188f2
test: Fix Lint error
hpatel292-seneca Dec 13, 2024
d009a9d
test: fix failing coverage thresholds red line unit test
JacopoPatroclo Apr 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test_runner: enhance #handleEvent to handle levels 
Updated to process the parameter for events. Messages
are now formatted with colors based on the
(e.g., 'info', 'warn', 'error').
This change ensures diagnostic messages are visually distinct,
improving clarity and reducing debugging effort during test runs.

Refs: #55922
  • Loading branch information
@hpatel292-seneca @JacopoPatroclo
hpatel292-seneca authored and JacopoPatroclo committed Apr 18, 2025
commit 3c9c4a834676ced04ce64c6ade42017e4633c540
6 changes: 4 additions & 2 deletions lib/internal/test_runner/reporter/spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,10 @@ class SpecReporter extends Transform {
case 'test:stderr':
case 'test:stdout':
return data.message;
case 'test:diagnostic':
return `${reporterColorMap[type]}${indent(data.nesting)}${reporterUnicodeSymbolMap[type]}${data.message}${colors.white}\n`;
case 'test:diagnostic':{
const diagnosticColor = reporterColorMap[data.level] || reporterColorMap['test:diagnostic'];
return `${diagnosticColor}${indent(data.nesting)}${reporterUnicodeSymbolMap[type]}${data.message}${colors.white}\n`;
}
case 'test:coverage':
return getCoverageReport(indent(data.nesting), data.summary,
reporterUnicodeSymbolMap['test:coverage'], colors.blue, true);
Expand Down