Skip to content

test_runner: support mocking json modules #58007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 4 commits into from
Apr 26, 2025
Merged

test_runner: support mocking json modules #58007

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8961496
test_runner: support mocking json modules
JakobJingleheimer Apr 24, 2025
17764f7
fixup!: de-lint
JakobJingleheimer Apr 24, 2025
32a4f02
fixup!: add test case to ensure import attributes are still required
JakobJingleheimer Apr 25, 2025
4e1ed7a
fixup!: don't pre-load original before testing rejection
JakobJingleheimer Apr 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup!: don't pre-load original before testing rejection 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
  • Loading branch information
@JakobJingleheimer @aduh95
JakobJingleheimer and aduh95 authored Apr 25, 2025
commit 4e1ed7a4e29f8751f994114970f9fcaf0543bcfe
6 changes: 1 addition & 5 deletions test/parallel/test-runner-module-mocking.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,15 +385,11 @@ test('JSON mocking', async (t) => {
await t.test('throws without appropriate import attributes', async (t) => {
const fixturePath = fixtures.path('module-mocking', 'basic.json');
const fixture = pathToFileurl("https://github.com/nodejs/node/pull/58007/commits/fixturePath");
const { default: original } = await import(fixture, { with: { type: 'json' } });

assert.deepStrictEqual(original, { foo: 'bar' });

const defaultExport = { qux: 'zed' };

t.mock.module(fixture, { defaultExport });

assert.rejects(() => import(fixture), /import attribute/);
await assert.rejects(() => import(fixture), /import attribute/);
});
});

Expand Down