Skip to content

test: reduce flakiness in test-heapdump-http2 #58148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
May 5, 2025
Merged

test: reduce flakiness in test-heapdump-http2 #58148

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: reduce flakiness in test-heapdump-http2 
By the time the response event is emitted on the client's side, the
file may have already been fully piped and the stream pipe
may have been destroyed, so the test should not look for the
stream pipe in the snapshot.
  • Loading branch information
@joyeecheung
joyeecheung committed May 3, 2025
commit 7f080a34028d1527b99b8f7bbc171a826b8897ce
7 changes: 3 additions & 4 deletions test/pummel/test-heapdump-http2.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,9 @@ server.listen(0, () => {
{ node_name: 'TCP', edge_name: 'native_to_javascript' },
]);

// `Node / StreamPipe` (C++) -> StreamPipe (JS)
validateByRetainingPathFromNodes(nodes, 'Node / StreamPipe', [
{ node_name: 'StreamPipe', edge_name: 'native_to_javascript' },
]);
// We don't necessarily have Node / StreamPipe here because by the time the
// response event is emitted, the file may have already been fully piped here
// and the stream pipe may have been destroyed.

// `Node / Http2Session` (C++) -> Http2Session (JS)
const sessions = validateByRetainingPathFromNodes(nodes, 'Node / Http2Session', []);
Expand Down