Skip to content

async_hooks: ensure AsyncLocalStore instances work isolated #58149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 3 commits into from
May 6, 2025
Merged

async_hooks: ensure AsyncLocalStore instances work isolated #58149

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
31fca27
async_hooks: ensure AsyncLocalStore instances work isolated
Flarna May 3, 2025
7d1c838
add comments to describe test steps
Flarna May 4, 2025
7f4ed98
improve/clarify ALS gcable test
Flarna May 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add comments to describe test steps
  • Loading branch information
@Flarna
Flarna committed May 4, 2025
commit 7d1c8380fd61eb778db0413bd4ed4bfb65ee79f3
2 changes: 2 additions & 0 deletions test/parallel/test-async-local-storage-isolation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ const assert = require('node:assert');
// Verify that ALS instances are independent of each other.

{
// Verify als2.enterWith() and als2.run inside als1.run()
const als1 = new AsyncLocalStorage();
const als2 = new AsyncLocalStorage();

Expand Down Expand Up @@ -33,6 +34,7 @@ const assert = require('node:assert');
}

{
Comment thread
Flarna marked this conversation as resolved.
// Verify als1.disable() has no side effects to als2 and als3
const als1 = new AsyncLocalStorage();
const als2 = new AsyncLocalStorage();
const als3 = new AsyncLocalStorage();
Expand Down