Skip to content

build: fix pointer compression builds #58171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joyeecheung wants to merge 2 commits into from
Closed

build: fix pointer compression builds #58171

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0447220
build: fix pointer compression builds
joyeecheung May 4, 2025
a3fab01
test: skip wasm-allocation tests for pointer compression builds
joyeecheung May 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: skip wasm-allocation tests for pointer compression builds 
V8 isolate group initialization forces allocation of the virtual
memory cage with pointer compression builds and simply would not
work when there is a smaller hard limit on the virtual memory.
  • Loading branch information
@joyeecheung
joyeecheung committed May 4, 2025
commit a3fab01641b863222631700d65ee6d8f176f910d
2 changes: 1 addition & 1 deletion test/wasm-allocation/wasm-allocation.status
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@ prefix wasm-allocation

[true] # This section applies to all platforms

[$system!=linux || $asan==on]
[$system!=linux || $asan==on || $pointer_compression==on]
test-wasm-allocation: SKIP
4 changes: 4 additions & 0 deletions tools/test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1619,6 +1619,9 @@ def get_asan_state(vm, context):
asan = Execute([vm, '-p', 'process.config.variables.asan'], context).stdout.strip()
return "on" if asan == "1" else "off"

def get_pointer_compression_state(vm, context):
pointer_compression = Execute([vm, '-p', 'process.config.variables.v8_enable_pointer_compression'], context).stdout.strip()
return "on" if pointer_compression == "1" else "off"

def Main():
parser = BuildOptions()
Expand Down Expand Up @@ -1717,6 +1720,7 @@ def Main():
'arch': vmArch,
'type': get_env_type(vm, options.type, context),
'asan': get_asan_state(vm, context),
'pointer_compression': get_pointer_compression_state(vm, context),
}
test_list = root.ListTests([], path, context, arch, mode)
unclassified_tests += test_list
Expand Down