Skip to content

inspector: add mimeType and charset support to Network.Response #58192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 4 commits into from
May 28, 2025
Merged

inspector: add mimeType and charset support to Network.Response #58192

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aedcacc
inspector: add mimeType and charset support to Network.Response
islandryu May 6, 2025
255e375
fallback to empty string if charset param is missing
islandryu May 7, 2025
40d0ff9
default empty string
islandryu May 20, 2025
004588e
fix intend
islandryu May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fallback to empty string if charset param is missing
  • Loading branch information
@islandryu
islandryu committed May 19, 2025
commit 255e375a5369545d4317e058b45380d0123f537b
2 changes: 1 addition & 1 deletion lib/internal/inspector/network_http.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ function onClientResponseFinish({ request, response }) {
try {
const mimeTypeObj = new MIMEType(response.headers['content-type']);
mimeType = mimeTypeObj.essence || '';
charset = mimeTypeObj.params.get('charset');
charset = mimeTypeObj.params.get('charset') || '';
} catch {
mimeType = '';
charset = '';
Expand Down
2 changes: 1 addition & 1 deletion lib/internal/inspector/network_undici.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ function onClientResponseHeaders({ request, response }) {
const contentType = contentTypeKeyIndex !== -1 ? response.headers[contentTypeKeyIndex + 1].toString() : '';
const mimeTypeObj = new MIMEType(contentType);
mimeType = mimeTypeObj.essence || '';
charset = mimeTypeObj.params.get('charset');
charset = mimeTypeObj.params.get('charset') || '';
} catch {
mimeType = '';
charset = '';
Expand Down
28 changes: 28 additions & 0 deletions test/parallel/test-inspector-network-content-type.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,4 +142,32 @@ const test = (handleRequest, testSessionFunc) => new Promise((resolve) => {
)
);

await test(
(req, res) => {
res.setHeader('Content-Type', 'text/plain');
res.writeHead(200);
res.end('hello world\n');
},
common.mustCall((session) =>
new Promise((resolve) => {
session.on(
'Network.responseReceived',
common.mustCall(({ params }) => {
assert.strictEqual(params.response.mimeType, 'text/plain');
assert.strictEqual(params.response.charset, '');
})
);
session.on(
'Network.loadingFinished',
common.mustCall(({ params }) => {
assert.ok(params.requestId.startsWith('node-network-event-'));
assert.strictEqual(typeof params.timestamp, 'number');
resolve();
})
);
}),
2
)
);

})().then(common.mustCall());