Skip to content

fs: glob is stable, so should not emit experimental warnings #58236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
May 10, 2025
Merged

fs: glob is stable, so should not emit experimental warnings #58236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fs: glob is stable, so should not emit experimental warnings
  • Loading branch information
@theoludwig
theoludwig committed May 8, 2025
commit 2a9f442f0498dcb3bed33ac9a91282da87ea4f77
3 changes: 0 additions & 3 deletions lib/fs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,6 @@ const {
const { toPathIfFileURL } = require('internal/url');
const {
customPromisifyArgs: kCustomPromisifyArgsSymbol,
emitExperimentalWarning,
getLazy,
kEmptyObject,
promisify: {
Expand Down Expand Up @@ -3165,7 +3164,6 @@ function createWriteStream(path, options) {
const lazyGlob = getLazy(() => require('internal/fs/glob').Glob);

function glob(pattern, options, callback) {
emitExperimentalWarning('glob');
if (typeof options === 'function') {
callback = options;
options = undefined;
Expand All @@ -3185,7 +3183,6 @@ function glob(pattern, options, callback) {
}

function globSync(pattern, options) {
emitExperimentalWarning('globSync');
const Glob = lazyGlob();
return new Glob(pattern, options).globSync();
}
Expand Down
2 changes: 0 additions & 2 deletions lib/internal/fs/promises.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,6 @@ const pathModule = require('path');
const { isAbsolute } = pathModule;
const { toPathIfFileURL } = require('internal/url');
const {
emitExperimentalWarning,
getLazy,
kEmptyObject,
lazyDOMException,
Expand Down Expand Up @@ -1261,7 +1260,6 @@ async function* _watch(filename, options = kEmptyObject) {

const lazyGlob = getLazy(() => require('internal/fs/glob').Glob);
async function* glob(pattern, options) {
emitExperimentalWarning('glob');
const Glob = lazyGlob();
yield* new Glob(pattern, options).glob();
}
Expand Down
3 changes: 0 additions & 3 deletions lib/path.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ const {
} = require('internal/validators');

const {
emitExperimentalWarning,
isWindows,
getLazy,
} = require('internal/util');
Expand Down Expand Up @@ -1141,7 +1140,6 @@ const win32 = {
},

matchesGlob(path, pattern) {
emitExperimentalWarning('glob');
return lazyMatchGlobPattern()(path, pattern, true);
},

Expand Down Expand Up @@ -1618,7 +1616,6 @@ const posix = {
},

matchesGlob(path, pattern) {
emitExperimentalWarning('glob');
return lazyMatchGlobPattern()(path, pattern, false);
},

Expand Down