Skip to content

build,win: fix dll build #58357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Jun 2, 2025
Merged

build,win: fix dll build #58357

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93397e3
build,win: fix dll build
StefanStojanovic May 16, 2025
d9a13d6
fix: resolve PR review
StefanStojanovic May 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
build,win: fix dll build 
Fixes: #58208
  • Loading branch information
@StefanStojanovic
StefanStojanovic committed May 30, 2025
commit 93397e3fcf73aa2dd26c0c4769c16d3c689dbb47
4 changes: 4 additions & 0 deletions src/node_builtins.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,10 @@ BuiltinLoader::BuiltinLoader()
#endif // HAVE_AMARO
}

auto BuiltinLoader::GetBuiltinIds() const -> decltype(auto) {
return std::views::keys(*source_.read());
}

bool BuiltinLoader::Exists(const char* id) {
auto source = source_.read();
return source->find(id) != source->end();
Expand Down
4 changes: 1 addition & 3 deletions src/node_builtins.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,9 +127,7 @@ class NODE_EXTERN_PRIVATE BuiltinLoader {

void CopySourceAndCodeCacheReferenceFrom(const BuiltinLoader* other);

[[nodiscard]] auto GetBuiltinIds() const {
return std::views::keys(*source_.read());
}
[[nodiscard]] auto GetBuiltinIds() const -> decltype(auto);
Comment thread
legendecas marked this conversation as resolved.
Outdated

void SetEagerCompile() { should_eager_compile_ = true; }

Expand Down