Skip to content

benchmark: add callback-based fs.glob to glob benchmark #58417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 3 commits into from
May 25, 2025
Merged

benchmark: add callback-based fs.glob to glob benchmark #58417

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
65c4619
benchmark: add callback-based `fs.glob` to glob benchmark
LiviaMedeiros May 22, 2025
531d6be
squash: optimize benchmark
LiviaMedeiros May 22, 2025
9593907
squash: lint
LiviaMedeiros May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
squash: optimize benchmark
  • Loading branch information
@LiviaMedeiros
LiviaMedeiros committed May 22, 2025
commit 531d6be411c8f79d247d3c6ecd2aa9ae718fb582
30 changes: 18 additions & 12 deletions benchmark/fs/bench-glob.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
'use strict';

const common = require('../common');
const fs = require('fs');
const {
glob,
globSync,
promises: { glob: globAsync },
} = require('fs');
const path = require('path');
const assert = require('node:assert');

Expand All @@ -20,28 +24,30 @@
async function main(config) {
const fullPath = path.resolve(benchmarkDirectory, config.dir);
const { pattern, recursive, mode } = config;
const options = { cwd: fullPath, recursive };
const callback = (resolve, reject) => {
glob(pattern, options, (err, matches) => {
if (err) {
reject(err)

Check failure on line 31 in benchmark/fs/bench-glob.js

View workflow job for this annotation

GitHub Actions / lint-js-and-md 

Missing semicolon
} else {
resolve(matches);
}
});
}

Check failure on line 36 in benchmark/fs/bench-glob.js

View workflow job for this annotation

GitHub Actions / lint-js-and-md 

Missing semicolon

let noDead;
bench.start();

for (let i = 0; i < config.n; i++) {
switch (mode) {
case 'sync':
noDead = fs.globSync(pattern, { cwd: fullPath, recursive });
noDead = globSync(pattern, options);
break;
case 'promise':
noDead = await fs.promises.glob(pattern, { cwd: fullPath, recursive });
noDead = await globAsync(pattern, options);
break;
case 'callback':
noDead = await new Promise((resolve, reject) => {
fs.glob(pattern, { cwd: fullPath, recursive }, (err, matches) => {
if (err) {
reject(err);
} else {
resolve(matches);
}
});
});
noDead = await new Promise(callback);
break;
default:
throw new Error(`Unknown mode: ${mode}`);
Expand Down
Loading