Skip to content

benchmark: fix broken fs.cpSync benchmark #58472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
May 27, 2025
Merged

benchmark: fix broken fs.cpSync benchmark #58472

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
benchmark: fix broken fs.cpSync benchmark
  • Loading branch information
@dario-piotrowicz
dario-piotrowicz committed May 26, 2025
commit ca19f7325252af6e9cbffb76b7f03f9c19d1bd26
5 changes: 4 additions & 1 deletion benchmark/fs/bench-cpSync.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,10 @@ const tmpdir = require('../../test/common/tmpdir');
const bench = common.createBenchmark(main, {
n: [1, 100, 10_000],
dereference: ['true', 'false'],
force: ['true', 'false'],
// When `force` is `true` the `cpSync` function is called twice the second
// time however an `ERR_FS_CP_EINVAL` is thrown, so skip `true` for the time being
// TODO: allow `force` to also be `true` once https://github.com/nodejs/node/issues/58468 is addressed
force: ['false'],
});

function prepareTestDirectory() {
Expand Down
Loading