Skip to content

New SQlite database options #58697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 11 commits into from
Jun 24, 2025
Merged

New SQlite database options #58697

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
6836df6
sqlite: add support for readBigInts option in db connection level
miguelmarcondesf Jun 11, 2025
68889b1
sqlite: add readBigInts as env property
miguelmarcondesf Jun 12, 2025
2f589fa
sqlite: add support for returnArrays option in db connection
miguelmarcondesf Jun 12, 2025
88be767
sqlite: add support for allowBareNamedParameters option in db connection
miguelmarcondesf Jun 12, 2025
917a093
sqlite: add support for allowUnknownNamedParameters option in db conn…
miguelmarcondesf Jun 12, 2025
1aca01e
doc: document new options for database connection
miguelmarcondesf Jun 12, 2025
7f0c06b
doc: update SQLite documentation with changes
miguelmarcondesf Jun 17, 2025
d7f08c0
test: remove redundant default values tests
miguelmarcondesf Jun 18, 2025
a0d04ad
doc: fix replacemme
miguelmarcondesf Jun 18, 2025
8839375
sqllite: add Raw string literals
miguelmarcondesf Jun 18, 2025
5693d3c
test: update error messages
miguelmarcondesf Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
sqlite: add readBigInts as env property
  • Loading branch information
@miguelmarcondesf
miguelmarcondesf committed Jun 12, 2025
commit 68889b1da77042f817102dcb451b76f7f1f7863c
1 change: 1 addition & 0 deletions src/env_properties.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,6 +324,7 @@
V(raw_string, "raw") \
V(read_host_object_string, "_readHostObject") \
V(readable_string, "readable") \
V(read_bigints_string, "readBigInts") \
V(reason_string, "reason") \
V(refresh_string, "refresh") \
V(regexp_string, "regexp") \
Expand Down
23 changes: 12 additions & 11 deletions src/node_sqlite.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -950,20 +950,20 @@ void DatabaseSync::New(const FunctionCallbackInfo<Value>& args) {
allow_load_extension = allow_extension_v.As<Boolean>()->Value();
}

Local<String> read_bigints_string =
FIXED_ONE_BYTE_STRING(env->isolate(), "readBigInts");
Local<Value> read_bigints_v;
if (options->Get(env->context(), read_bigints_string)
if (options->Get(env->context(), env->read_bigints_string())
.ToLocal(&read_bigints_v)) {
if (!read_bigints_v->IsUndefined()) {
if (!read_bigints_v->IsBoolean()) {
THROW_ERR_INVALID_ARG_TYPE(
env->isolate(),
"The \"options.readBigInts\" argument must be a boolean.");
return;
}
open_config.set_use_big_ints(read_bigints_v.As<Boolean>()->Value());
return;
}

if (!read_bigints_v->IsUndefined()) {
if (!read_bigints_v->IsBoolean()) {
THROW_ERR_INVALID_ARG_TYPE(
env->isolate(),
"The \"options.readBigInts\" argument must be a boolean.");
return;
}
open_config.set_use_big_ints(read_bigints_v.As<Boolean>()->Value());
}

Local<Value> timeout_v;
Expand Down Expand Up @@ -1789,6 +1789,7 @@ StatementSync::StatementSync(Environment* env,
MakeWeak();
statement_ = stmt;
use_big_ints_ = db_->use_big_ints();

// In the future, some of these options could be set at the database
// connection level and inherited by statements to reduce boilerplate.
return_arrays_ = false;
Expand Down