Skip to content

assert: cap input size in myersDiff to avoid Int32Array overflow #59578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 4 commits into from
Sep 9, 2025
Merged

assert: cap input size in myersDiff to avoid Int32Array overflow #59578

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c49523e
assert: cap input size in myersDiff to avoid Int32Array overflow
haramj Aug 22, 2025
604e516
Update lib/internal/assert/myers_diff.js
haramj Aug 28, 2025
219e2f6
assert: use 2 ** 31 - 1 instead of 0x7FFFFFFF for clarity
haramj Aug 28, 2025
8acf644
test: add myersDiff out-of-range input test
haramj Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update lib/internal/assert/myers_diff.js 
Co-authored-by: René <contact.9a5d6388@renegade334.me.uk>
  • Loading branch information
@haramj @Renegade334
haramj and Renegade334 authored Aug 28, 2025
commit 604e5165a2e68301b50b9b040134957e9b866b0b
2 changes: 1 addition & 1 deletion lib/internal/assert/myers_diff.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ function myersDiff(actual, expected, checkCommaDisparity = false) {
if (max > 0x7FFFFFFF) {
Comment thread
haramj marked this conversation as resolved.
Outdated
throw new ERR_OUT_OF_RANGE(
'myersDiff input size',
'< 2^31 - 1',
'< 2^31',
max,
);
}
Expand Down
Loading