Skip to content

Revert "lib: optimize writable stream buffer clearing" #59743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Sep 8, 2025
Merged

Revert "lib: optimize writable stream buffer clearing" #59743

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Revert "lib: optimize writable stream buffer clearing" 
This reverts commit 8a2fec1.
  • Loading branch information
@ri7116
ri7116 authored Sep 3, 2025
commit ce2041877e00dfa0f2c340108b274f44e5d54352
2 changes: 1 addition & 1 deletion lib/internal/streams/writable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -784,7 +784,7 @@ function clearBuffer(stream, state) {
if (i === buffered.length) {
resetBuffer(state);
} else if (i > 256) {
state[kBufferedValue] = ArrayPrototypeSlice(buffered, i);
buffered.splice(0, i);
state.bufferedIndex = 0;
} else {
state.bufferedIndex = i;
Expand Down
Loading