Skip to content

build: do not include custom ESLint rules testing in tarball #59809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduh95 merged 1 commit into from
Sep 10, 2025
+1 −10
Merged

build: do not include custom ESLint rules testing in tarball #59809

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
build: do not include custom ESLint rules testing in tarball 
PR-URL: #59809
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
@aduh95
aduh95 committed Sep 10, 2025
commit 6a46f31144f4dd03e21725ac5f9f7294f0d8b13b
10 changes: 0 additions & 10 deletions .github/workflows/build-tarball.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,15 +99,5 @@ jobs:
echo "TAR_DIR=$RUNNER_TEMP/$(basename tarballs/*.tar.gz .tar.gz)" >> "$GITHUB_ENV"
- name: Build
run: make -C "$TAR_DIR" build-ci -j4 V=1
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
persist-credentials: false
sparse-checkout: |
tools/eslint
tools/eslint-rules
- name: Move directories needed for testing
run: |
mv tools/eslint "$TAR_DIR/tools"
mv tools/eslint-rules "$TAR_DIR/tools"
- name: Test
run: make -C "$TAR_DIR" run-ci -j4 V=1 TEST_CI_ARGS="-p dots --measure-flakiness 9"
1 change: 1 addition & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1227,6 +1227,7 @@ $(TARBALL): release-only doc-only
$(RM) -r $(TARNAME)/tools/cpplint.py
$(RM) -r $(TARNAME)/tools/eslint
$(RM) -r $(TARNAME)/tools/eslint-rules
$(RM) -r $(TARNAME)/test/parallel/test-eslint-*
$(RM) -r $(TARNAME)/tools/license-builder.sh
$(RM) -r $(TARNAME)/tools/eslint/node_modules
$(RM) -r $(TARNAME)/tools/osx-*
Expand Down
Loading