Skip to content

module: only put directly require-d ESM into require.cache #59874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Sep 17, 2025
Merged

module: only put directly require-d ESM into require.cache #59874

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9fdaed
module: only put directly require-d ESM into require.cache
joyeecheung Sep 12, 2025
787d53a
fixup! module: only put directly require-d ESM into require.cache
joyeecheung Sep 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! module: only put directly require-d ESM into require.cache
  • Loading branch information
@joyeecheung
joyeecheung committed Sep 13, 2025
commit 787d53abba6acd1afd6ad2305ae1da1c0e95d515
1 change: 0 additions & 1 deletion lib/internal/modules/esm/loader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ const {
const {
kIsExecuting,
kRequiredModuleSymbol,
Module: CJSModule,
} = require('internal/modules/cjs/loader');
const { imported_cjs_symbol } = internalBinding('symbols');

Expand Down
2 changes: 1 addition & 1 deletion test/es-module/test-esm-in-require-cache.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// This tests the behavior of ESM in require.cache when it's loaded from require.

'use strict';
require('../common');
const assert = require('node:assert');
const fixtures = require('../common/fixtures');
Expand Down
Loading