Skip to content

http: implement slab allocation for HTTP header parsing #61375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 7 commits into from
Feb 4, 2026
Merged

http: implement slab allocation for HTTP header parsing #61375

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
20bde47
http: implement slab allocation for HTTP header parsing
mertcanaltin Jan 13, 2026
9115556
lint
mertcanaltin Jan 13, 2026
5def150
benchmark: add fragmented HTTP header parsing benchmark
mertcanaltin Jan 15, 2026
56393d3
implement shared slab allocation
mertcanaltin Jan 15, 2026
266bfdb
rename Allocate call
mertcanaltin Jan 21, 2026
b9090c9
optimize StringPtrAllocator memory management
mertcanaltin Jan 21, 2026
3d643fe
refactor StringPtr and Parser to use allocator parameter in Save and …
mertcanaltin Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
refactor StringPtr and Parser to use allocator parameter in Save and … 
…Update methods
  • Loading branch information
@mertcanaltin
mertcanaltin committed Jan 21, 2026
commit 3d643fe0f89417546f9d37658f3bf1837cc92815
45 changes: 17 additions & 28 deletions src/node_http_parser.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,19 +161,17 @@ struct StringPtr {
StringPtr(const StringPtr&) = delete;
StringPtr& operator=(const StringPtr&) = delete;

void SetAllocator(StringPtrAllocator* allocator) { allocator_ = allocator; }

// If str_ does not point to owned storage yet, this function makes it do
// so. This is called at the end of each http_parser_execute() so as not
// to leak references. See issue #2438 and test-http-parser-bad-ref.js.
void Save() {
void Save(StringPtrAllocator* allocator) {
if (str_ == nullptr || on_heap_ ||
(allocator_ != nullptr && allocator_->Contains(str_))) {
(allocator != nullptr && allocator->Contains(str_))) {
return;
}
// Try allocator first, fall back to heap
if (allocator_ != nullptr) {
char* ptr = allocator_->TryAllocate(size_);
if (allocator != nullptr) {
char* ptr = allocator->TryAllocate(size_);
if (ptr != nullptr) {
memcpy(ptr, str_, size_);
str_ = ptr;
Expand All @@ -195,19 +193,19 @@ struct StringPtr {
size_ = 0;
}

void Update(const char* str, size_t size) {
void Update(const char* str, size_t size, StringPtrAllocator* allocator) {
if (str_ == nullptr) {
str_ = str;
} else if (on_heap_ ||
(allocator_ != nullptr && allocator_->Contains(str_)) ||
(allocator != nullptr && allocator->Contains(str_)) ||
str_ + size_ != str) {
// Non-consecutive input, make a copy
const size_t new_size = size_ + size;
char* new_str = nullptr;

// Try allocator first (if not already on heap)
if (!on_heap_ && allocator_ != nullptr) {
new_str = allocator_->TryAllocate(new_size);
if (!on_heap_ && allocator != nullptr) {
new_str = allocator->TryAllocate(new_size);
}

if (new_str != nullptr) {
Expand Down Expand Up @@ -245,7 +243,6 @@ struct StringPtr {
const char* str_ = nullptr;
bool on_heap_ = false;
size_t size_ = 0;
StringPtrAllocator* allocator_ = nullptr;
};

struct ParserComparator {
Expand Down Expand Up @@ -303,15 +300,7 @@ class Parser : public AsyncWrap, public StreamListener {
: AsyncWrap(binding_data->env(), wrap),
current_buffer_len_(0),
current_buffer_data_(nullptr),
binding_data_(binding_data) {
// Wire up all StringPtrs to use the shared allocator
for (size_t i = 0; i < kMaxHeaderFieldsCount; i++) {
fields_[i].SetAllocator(&allocator_);
values_[i].SetAllocator(&allocator_);
}
url_.SetAllocator(&allocator_);
status_message_.SetAllocator(&allocator_);
}
binding_data_(binding_data) {}

SET_NO_MEMORY_INFO()
SET_MEMORY_INFO_NAME(Parser)
Expand Down Expand Up @@ -360,7 +349,7 @@ class Parser : public AsyncWrap, public StreamListener {
return rv;
}

url_.Update(at, length);
url_.Update(at, length, &allocator_);
return 0;
}

Expand All @@ -371,7 +360,7 @@ class Parser : public AsyncWrap, public StreamListener {
return rv;
}

status_message_.Update(at, length);
status_message_.Update(at, length, &allocator_);
return 0;
}

Expand All @@ -397,7 +386,7 @@ class Parser : public AsyncWrap, public StreamListener {
CHECK_LT(num_fields_, kMaxHeaderFieldsCount);
CHECK_EQ(num_fields_, num_values_ + 1);

fields_[num_fields_ - 1].Update(at, length);
fields_[num_fields_ - 1].Update(at, length, &allocator_);

return 0;
}
Expand All @@ -418,7 +407,7 @@ class Parser : public AsyncWrap, public StreamListener {
CHECK_LT(num_values_, arraysize(values_));
CHECK_EQ(num_values_, num_fields_);

values_[num_values_ - 1].Update(at, length);
values_[num_values_ - 1].Update(at, length, &allocator_);

return 0;
}
Expand Down Expand Up @@ -646,15 +635,15 @@ class Parser : public AsyncWrap, public StreamListener {
}

void Save() {
url_.Save();
status_message_.Save();
url_.Save(&allocator_);
status_message_.Save(&allocator_);

for (size_t i = 0; i < num_fields_; i++) {
fields_[i].Save();
fields_[i].Save(&allocator_);
}

for (size_t i = 0; i < num_values_; i++) {
values_[i].Save();
values_[i].Save(&allocator_);
}
}

Expand Down
Loading