Skip to content

docs: ✏️ fixed benchmark links#2991

Merged
ronag merged 1 commit into
nodejs:mainfrom
benhalverson:benchmark-link-fix
Mar 25, 2024
Merged

docs: ✏️ fixed benchmark links#2991
ronag merged 1 commit into
nodejs:mainfrom
benhalverson:benchmark-link-fix

Conversation

@benhalverson

@benhalverson benhalverson commented Mar 25, 2024

Copy link
Copy Markdown
Member

Changes

Fixed the broken links for benchmarks.js and post-benchmark.js

@codecov-commenter

codecov-commenter commented Mar 25, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.49%. Comparing base (bc304ff) to head (4bc96b2).
Report is 424 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2991   +/-   ##
=======================================
  Coverage   93.49%   93.49%           
=======================================
  Files          89       89           
  Lines       24225    24225           
=======================================
  Hits        22649    22649           
  Misses       1576     1576           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KhafraDev

Copy link
Copy Markdown
Member

can you use relative links?

@benhalverson

Copy link
Copy Markdown
Member Author

can you use relative links?

I don't think so because benchmark.js and post-benchmark.js are outside the docs directory.
I tried [example](../benchmarks/benchmark.js) and the original code was [example](.benchmarks/benchmark.js) both return 404
I also tried this https://docsify.js.org/#/helpers?id=ignore-to-compile-link

it might be possible with a plugin for docsify but I've never used this package and nothing sticks out in this plugin list.
https://docsify.js.org/#/awesome?id=plugins

If benchmark.js was in the docs directory would you want to load just the js or would it be in a markdown file like the existing examples?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants