Skip to content

fix: retry on body support #3294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ronag merged 7 commits into from
May 29, 2024
Merged

fix: retry on body support #3294

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c4b4e02
test: add testing
metcoder95 May 22, 2024
93a0959
Merge branch 'main' into fix/retry_iterator
metcoder95 May 22, 2024
38e6a6c
refactor: enhance body wrapping
metcoder95 May 24, 2024
d1e3516
Merge branch 'main' into fix/retry_iterator
metcoder95 May 24, 2024
82d7fb3
fix: do not mutate original opts
metcoder95 May 29, 2024
af2162e
Merge branch 'main' into fix/retry_iterator
metcoder95 May 29, 2024
735a72f
docs: extend documentation
metcoder95 May 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: do not mutate original opts
  • Loading branch information
@metcoder95
metcoder95 committed May 29, 2024
commit 82d7fb30e47e6c4b25eaaeec833299060a047de2
3 changes: 1 addition & 2 deletions lib/handler/retry-handler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ class RetryHandler {

this.dispatch = handlers.dispatch
this.handler = handlers.handler
this.opts = dispatchOpts
this.opts = { ...dispatchOpts, body: wrapRequestBody(opts.body) }
this.abort = null
this.aborted = false
this.retryOpts = {
Expand Down Expand Up @@ -68,7 +68,6 @@ class RetryHandler {
this.end = null
this.etag = null
this.resume = null
this.opts.body = wrapRequestBody(this.opts.body)

// Handle possible onConnect duplication
this.handler.onConnect(reason => {
Expand Down
8 changes: 2 additions & 6 deletions test/retry-handler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ test('Should account for network and response errors', async t => {
await t.completed
})

test('Issue #3288', async t => {
test('Issue #3288 - request with body (asynciterable)', async t => {
t = tspl(t, { plan: 6 })
const server = createServer()
const dispatchOptions = {
Expand Down Expand Up @@ -244,7 +244,6 @@ test('Issue #3288', async t => {
return true
},
onData (chunk) {
console.log('chunk', chunk)
return true
},
onComplete () {
Expand Down Expand Up @@ -755,7 +754,6 @@ test('retrying a request with a body', async t => {
t = tspl(t, { plan: 1 })

server.on('request', (req, res) => {
console.log({ counter })
switch (counter) {
case 0:
req.destroy()
Expand Down Expand Up @@ -835,7 +833,6 @@ test('retrying a request with a body (stream)', async t => {
t = tspl(t, { plan: 3 })

server.on('request', (req, res) => {
console.log({ counter })
switch (counter) {
case 0:
res.writeHead(500)
Expand Down Expand Up @@ -988,8 +985,7 @@ test('should not error if request is not meant to be retried', async t => {
t.strictEqual(Buffer.concat(chunks).toString('utf-8'), 'Bad request')
},
onError (err) {
console.log({ err })
t.fail()
t.fail(err)
}
}
})
Expand Down