Enable stream scanning#2
Open
admacleod wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This stream scanning implementation is added "inside" the existing string based Parse functions to ensure backwards compatibility and to reuse the existing test suite.
The reason for this change is to reduce the memory usage of the parser for stream based sources, mostly files. Rather than having to read an entire file into memory it can instead be streamed in chunks.
We've been making use of your fork of https://github.com/waigani/diffparser because it has some critical fixes around renamed files.
However an additional issue that we noticed was that when trying to diff larger files they both need to be read into memory before they can be parsed, so we added a streaming implementation which resolves that issue.
If you would rather we can switch this PR to the waigani project, but it seems to be pretty inactive right now, but we am happy to do so if you would rather we did that.