perf(nuxt): use reducer array and avoid crashing if prototype is modified#28768
Merged
Conversation
|
|
Contributor
|
Thanks for working through all the examples and code reproduction code with me Daniel ❤️❤️❤️ |
Eckhardt-D
reviewed
Aug 31, 2024
Merged
danielroe
added a commit
that referenced
this pull request
Sep 3, 2024
Merged
Kamsou
pushed a commit
to Kamsou/nuxt
that referenced
this pull request
Feb 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves #28769
📚 Description
devalueiterates over all properties (including prototype properties) of reducers passed to it (see sveltejs/devalue#80). There may possibly be some valid use cases where users modify an object prototype, and this PR ensures that a Nuxt server won't crash in this case.Regardless, for clarity, I would advise against mutating prototypes - plenty of other things may well crash in this case, without it being a bug or issue.
thanks to @lirantal for the original issue and working through this with me ❤️