🐛 Skip CODEOWNERS file in contributors check if there is a parsing error#4851
Merged
Conversation
Signed-off-by: juanis2112 <juanitagomezr2112@gmail.com>
6941e8e to
7214d48
Compare
spencerschrock
approved these changes
Nov 19, 2025
spencerschrock
left a comment
Member
There was a problem hiding this comment.
I plan to open an issue in the hmarr/codeowners
package, as I believe they could benefit from supporting the ^ character in their parsing patterns
Is that a valid CODEOWNERS character? I noticed the upstream VLLM fixed their codeowners, so I suspect it was a temporary mistake.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4851 +/- ##
==========================================
+ Coverage 66.80% 69.59% +2.78%
==========================================
Files 230 251 +21
Lines 16602 15657 -945
==========================================
- Hits 11091 10896 -195
+ Misses 4808 3891 -917
- Partials 703 870 +167 🚀 New features to boost your workflow:
|
Signed-off-by: juanis2112 <juanitagomezr2112@gmail.com>
thomasleplus
pushed a commit
to thomasleplus/scorecard
that referenced
this pull request
Mar 8, 2026
…ror (ossf#4851) * skip codeowners file if there is a parsing error Signed-off-by: juanis2112 <juanitagomezr2112@gmail.com> * Add log for codeowners parsing error Signed-off-by: juanis2112 <juanitagomezr2112@gmail.com> --------- Signed-off-by: juanis2112 <juanitagomezr2112@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug Fix
What is the current behavior?
When running scorecard on the repo: https://github.com/IBM/vllm I run into the following error:
What is the new behavior (if this is a feature change)?**
The Codeowners file is skipped if there are parsing errors found so now running scorecard on the repo https://github.com/IBM/vllm shows a score instead of error.
Which issue(s) this PR fixes
Fixes #4768
Special notes for your reviewer
I plan to open an issue in the hmarr/codeowners
package, as I believe they could benefit from supporting the ^ character in their parsing patterns. Regardless, it’s better for Scorecards to skip the CODEOWNERS file if a parsing error occurs and still produce a score, rather than invalidating the entire check. This change addresses that need.
We could optionally print a message to inform the user that a CODEOWNERS file was skipped, happy to add that if it’s useful.
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)