hey @burdges can you take a quick second look on this?

Thanks!

Oops, this fell off my radar, sorry! I have not checked the conversion of all the test vectors or ate_loop_* but otherwise everything makes sense.

There is however one Rust issue though, ate_loop_count_naf() allocates needlessly, as you never write to the result, so it should be replaced by

const ATE_LOOP_COUNT_NAF : [u8; 64] = [1,0,1,0,0,0,3,0,3,0,0,0,3,0,1,0,3,0,0,3,0,0,0,0,0,1,0,0,3,0,1,0,0,3,0,0,0,0,3,0,1,0,0,0,3,0,3,0,0,1,0,0,0,3,0,0,3,0,1,0,1,0,0,0];

As an aside, even if you wrote to the result, then for a short array like this you should return a [u8; 64] directly. Vec should be avoided unless you cannot know the length in advance

Oops, this fell off my radar, sorry! I have not checked the conversion of all the test vectors or ate_loop_* but otherwise everything makes sense.

There is however one Rust issue though, ate_loop_count_naf() allocates needlessly, as you never write to the result, so it should be replaced by

const ATE_LOOP_COUNT_NAF : [u8; 64] = [1,0,1,0,0,0,3,0,3,0,0,0,3,0,1,0,3,0,0,3,0,0,0,0,0,1,0,0,3,0,1,0,0,3,0,0,0,0,3,0,1,0,0,0,3,0,3,0,0,1,0,0,0,3,0,0,3,0,1,0,1,0,0,0];

As an aside, even if you wrote to the result, then for a short array like this you should return a [u8; 64] directly. Vec should be avoided unless you cannot know the length in advance

Heya, thanks for the feedback on this, rust is a language I'm somewhat unfamiliar with. Given the branch is merged, is it too late to push a change to fix this?

is it too late to push a change to fix this?

Yes. If you have the time it would be fantastic if you opened a second PR. Otherwise I can do it. :)