statement store: Implement basic statement-store support by AndreiEres · Pull Request #3127 · paritytech/smoldot

AndreiEres · 2026-03-16T15:43:03Z

Summary:

Based on https://github.com/bkchr/smoldot/tree/bkchr-battleship
Implements the Statement Store networking protocol for peer-to-peer statement distribution
Adds JSON-RPC methods for submitting and subscribing to statements

Protocol Implementation:

Statement encoding/decoding
Topic-based filtering with three modes: Any, MatchAll, and MatchAny
Duplicate detection via LRU cache of statement hashes

Network Layer:

New StatementProtocolConfig for enabling the protocol on a chain
Statement notification substream handling
StatementProtocolConnected and StatementNotification events

AndreiEres · 2026-03-16T15:44:30Z

/cmd fmt

alexggh

Had a pass, things are looking good to me. I put some comments, but nothing major.

One thing it is not clear to me is how do we want to test E2E, but that could be answered in followup PRs and issues.

dmitry-markin

Left some nits, but overall the approach looks good!

AndreiEres · 2026-03-24T16:39:12Z

@alexggh @dmitry-markin
Thank you for the thorough review.

There were many comments, so to avoid getting lost in them, I resolved the fixed or outdated ones and left some with my answers. I would greatly appreciate it if you could take another look.

dmitry-markin

Everything looks good, but let's move the statement-chat folder to a dedicated repo before merging the PR.

Co-authored-by: Dmitry Markin <dmitry@markin.tech>

dmitry-markin

Thanks for the solid PR! The implementation is clean and well-scoped. Ready for merging.

dmitry-markin · 2026-03-30T07:24:46Z

                    continue;
                }

+                // TODO: not efficient on a big number of subscriptions


nit: a brief description of the current complexity would be nice (you can copy from the original comment).

bkchr · 2026-03-31T08:26:54Z

@AndreiEres let's get this merged if you are happy.

Summary: - Based on https://github.com/bkchr/smoldot/tree/bkchr-battleship - Implements the Statement Store networking protocol for peer-to-peer statement distribution - Adds JSON-RPC methods for submitting and subscribing to statements Protocol Implementation: - Statement encoding/decoding - Topic-based filtering with three modes: Any, MatchAll, and MatchAny - Duplicate detection via LRU cache of statement hashes Network Layer: - New StatementProtocolConfig for enabling the protocol on a chain - Statement notification substream handling - StatementProtocolConnected and StatementNotification events --------- Co-authored-by: Dmitry Markin <dmitry@markin.tech>

AndreiEres added 3 commits March 16, 2026 16:38

Add statement store protocol implementation

fd5f08d

Add statement-chat example

07d7b0c

Address review comments

0b0498b

AndreiEres added 5 commits March 17, 2026 08:59

Remove leftovers

709de22

Fix statement example

5636071

Thread statement store protocol config through JS addChain API

3d7eb0c

Remove unused OkIgnore variant from StatementSubmitResult

23dc726

Run cargo fmt

d361c49

AndreiEres requested review from alexggh, bkchr and dmitry-markin March 17, 2026 08:27

alexggh reviewed Mar 19, 2026

View reviewed changes

dmitry-markin reviewed Mar 19, 2026

View reviewed changes

AndreiEres added 3 commits March 23, 2026 15:23

Address PR review comments for statement codec and protocol names

c29ca6e

Address PR review comments for network service statement protocol

84347fa

Move seen_statements deduplication from lib to light-base

0facaf7

alexggh reviewed Mar 24, 2026

View reviewed changes

Comment thread lib/src/json_rpc/methods.rs Outdated

AndreiEres added 5 commits March 24, 2026 14:56

Address PR review comments for network_service.rs

aa66068

Replace StatementRef/ProofRef with owned Statement/Proof types

12afa15

Address PR review comments for json_rpc_service background

c98bbee

Rename statement_* JSON-RPC methods to statement_unstable_*

1ab7a2e

Add prerequisites docs to statement_test example

6661979

AndreiEres added 4 commits March 24, 2026 17:39

fmt

f750c4e

Update misleading comment

883044f

Add expectation to fail first on roundtrip encoding error

66f6cd9

Check submitted statements before broadcast

ea156d0

AndreiEres linked an issue Mar 26, 2026 that may be closed by this pull request

statement-store: Implement a working prototype of light node for non-production use paritytech/polkadot-sdk#11285

Closed

dmitry-markin reviewed Mar 27, 2026

View reviewed changes

dmitry-markin approved these changes Mar 27, 2026

View reviewed changes

AndreiEres and others added 8 commits March 27, 2026 16:58

Update lib/src/network/service.rs

85ce746

Co-authored-by: Dmitry Markin <dmitry@markin.tech>

Update light-base/src/json_rpc_service/background.rs

0a7877c

Co-authored-by: Dmitry Markin <dmitry@markin.tech>

Update light-base/src/json_rpc_service/background.rs

0b030a6

Co-authored-by: Dmitry Markin <dmitry@markin.tech>

Update light-base/src/json_rpc_service/background.rs

4fda68f

Co-authored-by: Dmitry Markin <dmitry@markin.tech>

Update light-base/src/json_rpc_service/background.rs

2d7e8d7

Co-authored-by: Dmitry Markin <dmitry@markin.tech>

Update README

fb27f3e

Remove examples

8539a52

Add todo

6b792e8

This was referenced Mar 27, 2026

statement-store: Processing statements received from network is inefficient on a big number of statements #3144

Closed

statement-store: Prepare a proper enum Errors #3145

Closed

Increase statement_subscriptions initial capacity to 16

36b99f5

This was referenced Mar 27, 2026

statement-store: use a dedicated statement notifications channel #3146

Open

statement-store: create a reverse index topic -> subscription #3147

Closed

AndreiEres added 6 commits March 27, 2026 17:48

Break long hex string in test into lines under 100 characters

8b8f9ed

Move TopicFilter from network codec to json_rpc::methods

df154c5

Move debug_assert to beginning of StatementsNotification match arm

2a64311

Move StatementProtocolConfig from network service to light-base

68ed467

fmt

e9e43ed

Use then_some instead of then with closure for statement protocol

2852c9a

dmitry-markin approved these changes Mar 30, 2026

View reviewed changes

Update todo comment

67b6cda

AndreiEres merged commit c3fdfd0 into main Mar 31, 2026
24 checks passed

AndreiEres deleted the ae-statement-store branch March 31, 2026 09:03

Uh oh!

Conversation

AndreiEres commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AndreiEres commented Mar 16, 2026

Uh oh!

alexggh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dmitry-markin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

AndreiEres commented Mar 24, 2026

Uh oh!

dmitry-markin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dmitry-markin left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dmitry-markin Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

bkchr commented Mar 31, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

AndreiEres commented Mar 16, 2026 •

edited

Loading

dmitry-markin left a comment •

edited

Loading