Enable runnable (WASM) examples for language.control-structures section#5462
Open
AllenJB wants to merge 4 commits into
Open
Enable runnable (WASM) examples for language.control-structures section#5462AllenJB wants to merge 4 commits into
AllenJB wants to merge 4 commits into
Conversation
lacatoire
reviewed
Apr 21, 2026
lacatoire
reviewed
Apr 21, 2026
lacatoire
reviewed
Apr 21, 2026
lacatoire
reviewed
Apr 21, 2026
Co-authored-by: Louis-Arnaud <la.catoire@gmail.com>
jordikroon
requested changes
May 7, 2026
jordikroon
left a comment
Member
There was a problem hiding this comment.
Most of these examples would really benefit from having a <screen> to see the expected output directly. Would you be able to add those?
…on (review amends: example output, split some examples)
lacatoire
reviewed
Jun 8, 2026
| &example.outputs; | ||
| <screen> | ||
| <![CDATA[ | ||
| i is equal to 0, 1 or 2 |
Member
There was a problem hiding this comment.
Suggested change
| i is equal to 0, 1 or 2 | |
| i is not equal to 0, 1 or 2 |
lacatoire
reviewed
Jun 8, 2026
| for ($i = 0; $i < 5; ++$i) { | ||
| if ($i == 2) | ||
| continue | ||
| continue; |
Member
There was a problem hiding this comment.
The surrounding text says "Omitting the semicolon after continue… an example of what you shouldn't do", so this example must keep continue without a semicolon to demonstrate the pitfall (continue print "$i\n";). Changing it to continue; makes the code do exactly the "expected" thing, which contradicts the prose. Since the no-semicolon form is a compile error on modern PHP, this snippet should be marked annotations="non-interactive" and reverted to continue (no ;), rather than "fixed".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #4799