use git cat-file -e instead of git rev-list in _rev_exists#3605
Open
ptarjan wants to merge 11 commits into
Open
use git cat-file -e instead of git rev-list in _rev_exists#3605ptarjan wants to merge 11 commits into
ptarjan wants to merge 11 commits into
Conversation
asottile
requested changes
Dec 26, 2025
Author
|
How is that different than the current implementation? |
This reverts commit 5a4235c.
asottile
reviewed
Dec 26, 2025
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
asottile
reviewed
Dec 26, 2025
Author
|
I mean I liked the == 0 since the docs explicitly talk about retuning 0
when the SHA exists but this is your project and I just want the
functionality. I’ll switch back to not
…On Fri, Dec 26, 2025 at 12:41 PM anthony sottile ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In pre_commit/commands/hook_impl.py
<#3605 (comment)>
:
> - return not subprocess.call(('git', 'rev-list', '--quiet', rev))
+ return not bool(
+ subprocess.call(
+ ('git', 'cat-file', '-e', rev),
+ stderr=subprocess.DEVNULL,
+ ),
+ )
not bool(...) is the same as not ... which you'll notice is *exactly what
the original code does*
—
Reply to this email directly, view it on GitHub
<#3605 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAJZT6M52IG7ENARCRZII34DW2QTAVCNFSM6AAAAACQCVVVUOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTMMJTHEZTAOBQHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Member
|
do you actually understand what |
Member
You're absolutely right! |
Author
|
Is there anything else on this PR you need from me? |
Author
Would you prefer anything else from me to get this merged? |
Author
|
@asottile didn't want a PR generated by Claude to be included in his repo so I generated this one by hand |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3604
https://git-scm.com/docs/git-cat-file