Skip to content

perf(query-compiler): emit compact query plans#5823

Draft
tensordreams wants to merge 26 commits into
mainfrom
prisma-client-perf-compact-plan-format-engines
Draft

perf(query-compiler): emit compact query plans#5823
tensordreams wants to merge 26 commits into
mainfrom
prisma-client-perf-compact-plan-format-engines

Conversation

@tensordreams

@tensordreams tensordreams commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Summary

/prisma-branch prisma-client-perf-compact-plan-format

Produces the compact query-plan format used by the matching Prisma consumer branch.

This branch replaces internal serialized query-plan shapes in lockstep with the Prisma runtime reader. It deliberately does not keep old/new internal compatibility branches.

Stack

  1. Prisma prerequisite PR: prisma-client-perf-render-datamapper-prereqs
  2. Prisma compact consumer PR: prisma-client-perf-compact-plan-format
  3. This PR: engines compact producer

Validation

  • cargo fmt --check
  • CARGO_TARGET_DIR=/home/aqrln.guest/prisma/.tmp/compact-plan-engines-target cargo check -p query-core
  • CARGO_TARGET_DIR=/home/aqrln.guest/prisma/.tmp/compact-plan-engines-target cargo check -p query-compiler
  • CARGO_TARGET_DIR=/home/aqrln.guest/prisma/.tmp/compact-plan-engines-target cargo test -p query-compiler --test queries

Notes

Do not merge this without the matching Prisma compact consumer branch. The /prisma-branch command above links engines CI to that Prisma branch.

@tensordreams
Omit empty query arg db types
4465591 
Signed-off-by: Alexey Orlenko's AI Agent <robot@aqrln.net>
@tensordreams
Omit non-list result field arity
d62fc98 
Signed-off-by: Alexey Orlenko's AI Agent <robot@aqrln.net>
@tensordreams
Serialize SQL string fragments compactly
b459bd1 
Signed-off-by: Alexey Orlenko's AI Agent <robot@aqrln.net>
@tensordreams
Omit default result field db names
033a41b 
Signed-off-by: Alexey Orlenko's AI Agent <robot@aqrln.net>
@tensordreams
Omit result field type tags
d84c638 
Signed-off-by: Alexey Orlenko's AI Agent <robot@aqrln.net>
@tensordreams
Compact scalar result field types
339f934 
Signed-off-by: Alexey Orlenko's AI Agent <robot@aqrln.net>
@tensordreams
Compact scalar query arg types
253dc57 
Signed-off-by: Alexey Orlenko's AI Agent <robot@aqrln.net>
@tensordreams
Compact scalar result field nodes
71e7fb9 
Signed-off-by: Alexey Orlenko's AI Agent <robot@aqrln.net>
@tensordreams
Compact template SQL queries
dc983ed 
Signed-off-by: Alexey Orlenko's AI Agent <robot@aqrln.net>
@tensordreams
Compact result object nodes
e71b423 
Signed-off-by: Alexey Orlenko's AI Agent <robot@aqrln.net>
@tensordreams
Compact expression nodes
8a84e87 
Signed-off-by: Alexey Orlenko's AI Agent <robot@aqrln.net>
@tensordreams
Compact in-memory ops serialization
4413e05 
Signed-off-by: Alexey Orlenko's AI Agent <robot@aqrln.net>
@tensordreams
Compact parameter fragments
f1d6b0f 
Signed-off-by: Alexey Orlenko's AI Agent <robot@aqrln.net>
@tensordreams
Compact tuple parameter fragments
c6b921f 
Signed-off-by: Alexey Orlenko's AI Agent <robot@aqrln.net>
@tensordreams
Compact Prisma value placeholders
42880aa 
Signed-off-by: Alexey Orlenko's AI Agent <robot@aqrln.net>
@tensordreams
Compact query plan support structures
e8597f6 
Signed-off-by: Alexey Orlenko's AI Agent <robot@aqrln.net>
@tensordreams
Compact query plan data rules
9bf6262 
Signed-off-by: Alexey Orlenko's AI Agent <robot@aqrln.net>
@tensordreams
Compact native scalar query arg types
ef857a7 
Signed-off-by: Alexey Orlenko's AI Agent <robot@aqrln.net>
@tensordreams
Compact Prisma value generator calls
4a0eadd 
Signed-off-by: Alexey Orlenko's AI Agent <robot@aqrln.net>
@tensordreams
Compact query plan validation errors
70ba882 
Signed-off-by: Alexey Orlenko's AI Agent <robot@aqrln.net>
@tensordreams
Compact scalar type names in query plans
43d00c5 
Signed-off-by: Alexey Orlenko's AI Agent <robot@aqrln.net>
@tensordreams
Omit empty data map enums
3a128e0 
Signed-off-by: Alexey Orlenko's AI Agent <robot@aqrln.net>
@tensordreams
Compact result field type scalars
98b3414 
Signed-off-by: Alexey Orlenko's AI Agent <robot@aqrln.net>
@tensordreams
Avoid result mapper lookup maps
c939f7e 
Signed-off-by: Alexey Orlenko's AI Agent <robot@aqrln.net>
@tensordreams
Avoid cloning result mapper selections
1cd08fd 
Signed-off-by: Alexey Orlenko's AI Agent <robot@aqrln.net>
@tensordreams
perf(query-compiler): store result object fields in vectors
aa48ae3 
Signed-off-by: Alexey Orlenko's AI Agent <robot@aqrln.net>
@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 39b98bbd-836f-4639-96f1-c53eeb59b8a7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch prisma-client-perf-compact-plan-format-engines
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch prisma-client-perf-compact-plan-format-engines

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@CLAassistant

CLAassistant commented Jun 25, 2026 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@codspeed-hq

codspeed-hq Bot commented Jun 25, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 11 untouched benchmarks
⏩ 11 skipped benchmarks1

Comparing prisma-client-perf-compact-plan-format-engines (aa48ae3) with main (1171e96)

Open in CodSpeed

Footnotes

  1. 11 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@github-actions

github-actions Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Wasm Query Compiler File Size

Engine This PR Base branch Diff
Postgres 3.479MiB 3.508MiB -29.609KiB
Postgres (gzip) 1.138MiB 1.143MiB -5.188KiB
Postgres (size-optimized) 1.759MiB 1.767MiB -7.993KiB
Postgres (size-optimized, gzip) 692.739KiB 695.610KiB -2.872KiB
Mysql 3.432MiB 3.461MiB -29.611KiB
Mysql (gzip) 1.122MiB 1.128MiB -5.245KiB
Mysql (size-optimized) 1.729MiB 1.737MiB -7.994KiB
Mysql (size-optimized, gzip) 681.238KiB 684.340KiB -3.103KiB
Sqlite 3.350MiB 3.378MiB -29.616KiB
Sqlite (gzip) 1.094MiB 1.099MiB -5.149KiB
Sqlite (size-optimized) 1.686MiB 1.693MiB -6.817KiB
Sqlite (size-optimized, gzip) 664.785KiB 667.397KiB -2.613KiB
SQL Server 3.567MiB 3.596MiB -29.629KiB
SQL Server (gzip) 1.155MiB 1.161MiB -5.680KiB
SQL Server (size-optimized) 1.759MiB 1.766MiB -6.875KiB
SQL Server (size-optimized, gzip) 695.637KiB 698.453KiB -2.816KiB
CockroachDB 3.529MiB 3.558MiB -29.614KiB
CockroachDB (gzip) 1.157MiB 1.162MiB -5.318KiB
CockroachDB (size-optimized) 1.786MiB 1.792MiB -6.822KiB
CockroachDB (size-optimized, gzip) 703.334KiB 705.560KiB -2.227KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tensordreams @CLAassistant