Skip to content

perf(query-compiler): prune update and upsert graph phases#5831

Draft
tensordreams wants to merge 4 commits into
prisma-client-perf-coc-branch-pruningfrom
prisma-client-perf-update-upsert-pruning
Draft

perf(query-compiler): prune update and upsert graph phases#5831
tensordreams wants to merge 4 commits into
prisma-client-perf-coc-branch-pruningfrom
prisma-client-perf-update-upsert-pruning

Conversation

@tensordreams

@tensordreams tensordreams commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Stacked performance split from the ongoing Prisma Client performance work.

What changed:

  • Stacks on connect-or-create pruning and removes redundant update/upsert graph phases, including narrow shared final-read and nested-only pass-through shapes.

Why:

  • Keeps this review unit small while preserving the measured allocation/runtime cleanup from the larger performance branch.

Validation:

  • See wip/client-performance-pr-stack.md on the Prisma status branch for the exact local check set recorded for this split.

CI linkage:
/prisma-branch prisma-client-performance-2026-06-08

@tensordreams
perf(query-compiler): skip nested-only update nodes
23d89d5 
Signed-off-by: Alexey Orlenko's AI Agent <robot@aqrln.net>
@tensordreams
perf(query-compiler): skip nested-only upsert update nodes
b99ebaa 
Signed-off-by: Alexey Orlenko's AI Agent <robot@aqrln.net>
@tensordreams
perf(query-compiler): skip noop upsert updates
50ba2fd 
Signed-off-by: Alexey Orlenko's AI Agent <robot@aqrln.net>
@tensordreams
test(query-compiler): refresh update upsert pruning snapshots
768be77 
Signed-off-by: Alexey Orlenko's AI Agent <robot@aqrln.net>
@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 35a34492-58f7-49b4-a38c-ef70e2988e99

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch prisma-client-perf-update-upsert-pruning
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch prisma-client-perf-update-upsert-pruning

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@CLAassistant

CLAassistant commented Jun 25, 2026 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@codspeed-hq

codspeed-hq Bot commented Jun 25, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 11 untouched benchmarks
⏩ 11 skipped benchmarks1

Comparing prisma-client-perf-update-upsert-pruning (768be77) with main (1171e96)2

Open in CodSpeed

Footnotes

  1. 11 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on prisma-client-perf-coc-branch-pruning (9a426d2) during the generation of this report, so main (1171e96) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@github-actions

github-actions Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Wasm Query Compiler File Size

Engine This PR Base branch Diff
Postgres 3.566MiB 3.552MiB 14.571KiB
Postgres (gzip) 1.164MiB 1.160MiB 4.413KiB
Postgres (size-optimized) 1.778MiB 1.785MiB -6.470KiB
Postgres (size-optimized, gzip) 703.139KiB 702.771KiB 377.000B
Mysql 3.519MiB 3.505MiB 14.614KiB
Mysql (gzip) 1.148MiB 1.144MiB 4.535KiB
Mysql (size-optimized) 1.748MiB 1.755MiB -6.467KiB
Mysql (size-optimized, gzip) 692.329KiB 691.500KiB 849.000B
Sqlite 3.437MiB 3.422MiB 14.571KiB
Sqlite (gzip) 1.121MiB 1.115MiB 5.252KiB
Sqlite (size-optimized) 1.704MiB 1.710MiB -6.470KiB
Sqlite (size-optimized, gzip) 674.641KiB 674.050KiB 605.000B
SQL Server 3.654MiB 3.640MiB 14.602KiB
SQL Server (gzip) 1.181MiB 1.177MiB 4.500KiB
SQL Server (size-optimized) 1.777MiB 1.783MiB -6.491KiB
SQL Server (size-optimized, gzip) 705.601KiB 705.336KiB 271.000B
CockroachDB 3.616MiB 3.602MiB 14.602KiB
CockroachDB (gzip) 1.183MiB 1.178MiB 4.509KiB
CockroachDB (size-optimized) 1.804MiB 1.810MiB -6.491KiB
CockroachDB (size-optimized, gzip) 713.128KiB 712.561KiB 581.000B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tensordreams @CLAassistant