Skip to content

tracing: fix startup failure for insecure OTLP HTTP tracing #18469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roidelapluie merged 2 commits into from
Apr 7, 2026
Merged

tracing: fix startup failure for insecure OTLP HTTP tracing #18469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b997a29
tracing: fix startup failure for insecure OTLP HTTP tracing
mumberrymountain Apr 5, 2026
027b763
tracing: add regression test for HTTP insecure mode
roidelapluie Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions tracing/tracing.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,14 @@ func getClient(tracingCfg config.TracingConfig) (otlptrace.Client, error) {
opts := []otlptracehttp.Option{otlptracehttp.WithEndpoint(tracingCfg.Endpoint)}
if tracingCfg.Insecure {
opts = append(opts, otlptracehttp.WithInsecure())
} else {
// Use of TLS Credentials forces the use of TLS. Therefore it can
// only be set when `insecure` is set to false.
tlsConf, err := config_util.NewTLSConfig(&tracingCfg.TLSConfig)
if err != nil {
return nil, err
}
opts = append(opts, otlptracehttp.WithTLSClientConfig(tlsConf))
}
// Currently, OTEL supports only gzip compression.
if tracingCfg.Compression == config.GzipCompression {
Expand All @@ -219,12 +227,6 @@ func getClient(tracingCfg config.TracingConfig) (otlptrace.Client, error) {
opts = append(opts, otlptracehttp.WithTimeout(time.Duration(tracingCfg.Timeout)))
}

tlsConf, err := config_util.NewTLSConfig(&tracingCfg.TLSConfig)
if err != nil {
return nil, err
}
opts = append(opts, otlptracehttp.WithTLSClientConfig(tlsConf))

client = otlptracehttp.NewClient(opts...)
}

Expand Down
12 changes: 12 additions & 0 deletions tracing/tracing_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,18 @@ func TestUninstallingTracerProvider(t *testing.T) {
require.Equal(t, noop.NewTracerProvider(), otel.GetTracerProvider())
}

func TestInstallingTracerProviderHTTPInsecure(t *testing.T) {
m := NewManager(promslog.NewNopLogger())
cfg := config.Config{
TracingConfig: config.TracingConfig{
Endpoint: "localhost:4318",
ClientType: config.TracingClientHTTP,
Insecure: true,
},
}
require.NoError(t, m.ApplyConfig(&cfg))
}

func TestTracerProviderShutdown(t *testing.T) {
m := NewManager(promslog.NewNopLogger())
cfg := config.Config{
Expand Down
Loading