Skip to content

promql: fix smoothed rate returning zero for data only after range #18523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roidelapluie merged 1 commit into from
Apr 16, 2026
+20 −1
Merged

promql: fix smoothed rate returning zero for data only after range #18523

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions promql/functions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,9 @@ func extendedRate(vals Matrix, args parser.Expressions, enh *EvalNodeHelper, isC
if f[lastSampleIndex].T <= rangeStart {
return enh.Out, annos
}
if smoothed && f[firstSampleIndex].T > rangeEnd {
return enh.Out, annos
}

left := pickOrInterpolateLeft(f, firstSampleIndex, rangeStart, smoothed, isCounter)
right := pickOrInterpolateRight(f, lastSampleIndex, rangeEnd, smoothed, isCounter)
Expand Down
18 changes: 17 additions & 1 deletion promql/promqltest/testdata/extended_vectors.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,4 +417,20 @@ eval instant at 45s withreset smoothed
withreset 3

eval instant at 30s notregular smoothed
notregular 2
notregular 2

# Smoothed rate returns empty when data is only before or only after the range.
clear
load 10s
metric _ 5+1x4

eval instant at 5s rate(metric[5s] smoothed)

eval instant at 5s increase(metric[5s] smoothed)

eval instant at 15s increase(metric[10s] smoothed)
{} 0.5

eval instant at 60s rate(metric[5s] smoothed)

eval instant at 60s increase(metric[5s] smoothed)
Loading