This repository was archived by the owner on Jul 10, 2026. It is now read-only.
update platforms/arch supported based on what modernc.org/libc is supporting#50
Merged
Merged
Conversation
…ibc is supporting Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
Member
|
👍 FYI @SuperQ |
Member
Author
|
For the records, here the code repo of the |
Member
Author
Member
|
I think we should just merge it for now so we can still do the release today. I think getting rid of CGO is nice enough to warrant dropping support for some of the more arcane platforms / archs. |
Member
|
Yea, this is fine. I also would prefer to avoid needing CGO for our builds. |
SuperQ
approved these changes
Nov 10, 2022
Member
Author
|
Nice ! Thanks @SuperQ ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #42, the build is failing on the main branch because some platforms/arch are not supported by modernc.org/libc.
This PR aligned the same amount of platform/arch currently supported by this lib. If we want to fallback this PR https://gitlab.com/cznic/libc/-/tree/master/unistd need to be updated with the platform missing.
By looking at the commits, it looks like the code is generated (perhaps partially)
Note:
dragonflyandillumosplatform have been removed.Signed-off-by: Augustin Husson husson.augustin@gmail.com