gh-111906: Remove unused function warnings during mimalloc build on FREEBSD#111907
Merged
Conversation
Contributor
|
cc. @vstinner, who have been interested in FreeBSD builds lately (IIRC). |
Member
|
!buildbot FreeBSD |
Member
|
In a recent FreeBSD 14 buildbot build, I see the following compiler warnings: I scheduled FreeBSD builds to see if the code still builds and if warnings are done. |
Member
|
With this change, build succeeded on the 3 FreeBSD buildbot jobs:
Moreover, I don't see compiler warnings anymore about |
Member
|
@DinoV: how can you make these changes upstream? I would prefer to not lose them at the next mimalloc sync. |
Member
|
Merged. Thanks @furkanonder for your fix. |
Contributor
Author
You are welcome. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.