Skip to content

closes bpo-36115: Fix some reference leaks in typeobject.c.#12045

Merged
miss-islington merged 1 commit into
python:masterfrom
benjaminp:typeobject-refleaks
Feb 26, 2019
Merged

closes bpo-36115: Fix some reference leaks in typeobject.c.#12045
miss-islington merged 1 commit into
python:masterfrom
benjaminp:typeobject-refleaks

Conversation

@benjaminp

@benjaminp benjaminp commented Feb 26, 2019

Copy link
Copy Markdown
Contributor

a24107b introduced a few refleaks.

https://bugs.python.org/issue36115

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @benjaminp.

@pablogsal

pablogsal commented Feb 26, 2019

Copy link
Copy Markdown
Member

This PR fixes https://bugs.python.org/issue36115 :)

@benjaminp

Copy link
Copy Markdown
Contributor Author

It fixes test_multiprocessing modifying the environment?

@pablogsal

Copy link
Copy Markdown
Member

The issue number was wrong, I have edited the comment

@benjaminp benjaminp changed the title Fix some reference leaks in typeobject.c. closes bpo-36115: Fix some reference leaks in typeobject.c. Feb 26, 2019
@pablogsal

Copy link
Copy Markdown
Member

For reference, it fixes refleaks detected on Ctypes:
https://buildbot.python.org/all/#/builders/1/builds/515

OK (skipped=89)
.
test_ctypes leaked [72, 72, 72] references, sum=216
test_ctypes leaked [26, 26, 26] memory blocks, sum=78
2 tests failed again:
test_ctypes test_inspect
== Tests result: FAILURE then FAILURE ==

https://bugs.python.org/issue36115

@miss-islington

Copy link
Copy Markdown
Contributor

@benjaminp: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit d5a551c into python:master Feb 26, 2019
@benjaminp benjaminp deleted the typeobject-refleaks branch February 26, 2019 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants