Skip to content

bpo-33944: Add site.py site-packages tracing in verbose mode#12110

Merged
methane merged 10 commits into
python:masterfrom
native-api:site_trace
Jun 12, 2020
Merged

bpo-33944: Add site.py site-packages tracing in verbose mode#12110
methane merged 10 commits into
python:masterfrom
native-api:site_trace

Conversation

@native-api

@native-api native-api commented Mar 1, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

methane
methane reviewed Mar 2, 2019
View reviewed changes
Comment thread Lib/site.py Outdated
methane
methane reviewed Mar 2, 2019
View reviewed changes
Comment thread Lib/site.py Outdated
methane and others added 2 commits March 2, 2019 20:28
@methane @native-api
code style fix
793a6a5 
Co-Authored-By: native-api <ivan_pozdeev@mail.ru>
@methane @native-api
use newer string formatting syntax
2b77747 
Co-Authored-By: native-api <ivan_pozdeev@mail.ru>
@methane

methane commented Mar 3, 2019

Copy link
Copy Markdown
Member

I didn't mean single place. I meant changing all % usages.

@native-api

native-api commented Mar 3, 2019

Copy link
Copy Markdown
Contributor Author

@methane: I didn't mean single place. I meant changing all % usages.

Well, the suggested change feature commits exactly what you suggested (I don't actually know if I can change it at all), and I didn't look any further, trusting your review.
Could you please do the task to completion? There may be yet other small things to fix or something.

@methane

methane commented Mar 3, 2019

Copy link
Copy Markdown
Member

and I didn't look any further, trusting your review.

Please don't trust me as such. I hope contributors is not robot just applying suggested change. I hope contributors understand and grow up by review.

Could you please do the task to completion? There may be yet other small things to fix or something.

At a code level, looks good me.
But I'm not sure that adding more PYTHON* env vars is really good thing for this particular case...

Adding more and more envvar makes it harder to users read manual and find option they needed by their self.

remilapeyre
remilapeyre reviewed Jun 6, 2020
View reviewed changes

@remilapeyre remilapeyre left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @native-api !

Comment thread Doc/using/cmdline.rst Outdated
Comment thread Lib/test/test_site.py Outdated
Comment thread Lib/test/test_site.py Outdated
Comment thread Lib/test/test_site.py Outdated
Comment thread Misc/NEWS.d/next/Library/2019-03-01-01-56-23.bpo-33944.-82Pkt.rst Outdated
remilapeyre
remilapeyre reviewed Jun 8, 2020
View reviewed changes
Comment thread Doc/using/cmdline.rst Outdated
@native-api
Update Doc/using/cmdline.rst
bf76e64 
Co-authored-by: Rémi Lapeyre <remi.lapeyre@henki.fr>
@methane methane merged commit 2145c8c into python:master Jun 12, 2020
@native-api native-api deleted the site_trace branch June 12, 2020 12:20
@warsaw warsaw mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@methane methane methane left review comments

+1 more reviewer

@remilapeyre remilapeyre remilapeyre approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@native-api @methane @remilapeyre @the-knights-who-say-ni @bedevere-bot