Skip to content

gh-131591: Add tests for _PdbClient #132976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 8 commits into from
Apr 30, 2025
Merged

gh-131591: Add tests for _PdbClient #132976

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
43847a4
Add tests for _PdbClient
godlygeek Apr 22, 2025
ac8aaf7
Address review comments
godlygeek Apr 28, 2025
102404c
Revert accidental formatting changes
godlygeek Apr 28, 2025
e56f788
Explicitly use the repr for bytes objects in error messages
godlygeek Apr 29, 2025
dd1bdab
Address review comments
godlygeek Apr 29, 2025
871c78f
Avoid mutable default arguments
godlygeek Apr 29, 2025
9144669
Correct fix to avoid mutable default args
godlygeek Apr 29, 2025
54087ca
Merge remote-tracking branch 'upstream/main' into remote_pdb_client_t…
godlygeek Apr 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Explicitly use the repr for bytes objects in error messages
  • Loading branch information
@godlygeek
godlygeek committed Apr 29, 2025
commit e56f7885808d367f3cf5219f377e2cb3fa219e78
4 changes: 2 additions & 2 deletions Lib/pdb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2610,7 +2610,7 @@ def _read_reply(self):
try:
payload = json.loads(msg)
except json.JSONDecodeError:
self.error(f"Disconnecting: client sent invalid JSON {msg}")
self.error(f"Disconnecting: client sent invalid JSON {msg!r}")
raise EOFError

match payload:
Expand Down Expand Up @@ -2917,7 +2917,7 @@ def cmdloop(self):
payload = json.loads(payload_bytes)
except json.JSONDecodeError:
print(
f"*** Invalid JSON from remote: {payload_bytes}",
f"*** Invalid JSON from remote: {payload_bytes!r}",
flush=True,
)
continue
Expand Down