bpo-36983: Fix typing.__all__ and add test for exported names#13456
Merged
Conversation
Carreau
approved these changes
May 29, 2019
Contributor
|
(also will need a rebase/fix conflicts.) |
cb7699d to
587dc7a
Compare
gvanrossum
approved these changes
May 29, 2019
Contributor
|
Sorry, I can't merge this PR. Reason: |
1 similar comment
Contributor
|
Sorry, I can't merge this PR. Reason: |
Contributor
|
Thanks @asottile for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
Contributor
|
I'm having trouble backporting to |
|
GH-13662 is a backport of this pull request to the 3.7 branch. |
|
GH-13663 is a backport of this pull request to the 3.6 branch. |
asottile
added a commit
to asottile/cpython
that referenced
this pull request
May 29, 2019
miss-islington
pushed a commit
that referenced
this pull request
May 30, 2019
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue36983