Skip to content

[3.14] gh-141442: Add escaping to iOS testbed arguments (GH-141443) #141479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
freakboy3742 merged 1 commit into from
Nov 12, 2025
Merged

[3.14] gh-141442: Add escaping to iOS testbed arguments (GH-141443) #141479

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
gh-141442: Add escaping to iOS testbed arguments (GH-141443) 
Xcode concatenates the test argument array, losing quoting in the process.
(cherry picked from commit 558936b)

Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
  • Loading branch information
@freakboy3742 @miss-islington
freakboy3742 authored and miss-islington committed Nov 12, 2025
commit 76e9e399a6e3e5e9623543ab55358ff4b83234ba
3 changes: 2 additions & 1 deletion Apple/testbed/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
import json
import os
import re
import shlex
import shutil
import subprocess
import sys
Expand Down Expand Up @@ -252,7 +253,7 @@ def update_test_plan(testbed_path, platform, args):
test_plan = json.load(f)

test_plan["defaultOptions"]["commandLineArgumentEntries"] = [
{"argument": arg} for arg in args
{"argument": shlex.quote(arg)} for arg in args
]

with test_plan_path.open("w", encoding="utf-8") as f:
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Tools-Demos/2025-11-12-12-54-28.gh-issue-141442.50dS3P.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
The iOS testbed now correctly handles test arguments that contain spaces.
Loading